Vueify Rules Edit #14878
Merged
Vueify Rules Edit #14878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
reviewed
Dec 3, 2022
|
|
||
| async function onEdit() { | ||
| if (props.target) { | ||
| const url = `${getAppRoot()}api/dataset_collections/${props.target.id}?instance_type=history`; |
There was a problem hiding this comment.
I know this is from the previous code, but we could use this opportunity to use UrlData from utils/url here. Thank you so much for working on this.
dannon
force-pushed
the
rules-edit-vue
branch
from
41ae134 to
b96abbd
Compare
|
Failed selenium test looks related: |
…ion. Checked, and these were still MIT licensed
ElectronicBlueberry
force-pushed
the
rules-edit-vue
branch
from
3f921eb to
c6a079e
Compare
dannon
approved these changes
Dec 9, 2022
|
This PR was merged without a "kind/" label, please correct. |
dannon
added
the
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12880
I attempted to write an automated test for this component, however importing RuleCollectionBuilder throws an error in jest, due to the "handsontable" dependency.
How to test the changes?
(Select all options that apply)
License